[Gpsbabel-code] Road Gradient srt patch

Discussion:

Giovanni Zilli

2015-06-17 18:43:50 UTC

Hello there!
This is my first ever svn patch, so please be patient with me :)
It is based on r4980, and it will add road gradient in percentage.

In this Youtube subtitles you can see a sample:

Thank you!

Giovanni

Robert Lipe

2015-06-17 20:09:06 UTC

Permalink

Welcome and thanx!

At a glance, this seems pretty reasonable. I'll make a few whitespace
changes, use %% instead of %c...37, and improve handling of unknown
altitudes, but it seems pretty good to me. I can do patient. :-)

If you can offer a sentence or two for the doc (that .xml file you edited)
and a simple file (it can be three points or something) that exercises this
and related formatting options in the test suite, that would be helpful,
but I won't block on it.

RJL

Post by Giovanni Zilli
Hello there!
This is my first ever svn patch, so please be patient with me :)
It is based on r4980, and it will add road gradient in percentage.
http://youtu.be/kAZPvd5Iy8E
Thank you!
Giovanni
------------------------------------------------------------------------------
_______________________________________________
Gpsbabel-code mailing list http://www.gpsbabel.org
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code

Robert Lipe

2015-06-20 13:36:48 UTC

Permalink

Submitted as revision 4999 with minor tweaks. Please do follow up with
those doc improvements and testo cases, please.

Post by Robert Lipe
Welcome and thanx!
At a glance, this seems pretty reasonable. I'll make a few whitespace
changes, use %% instead of %c...37, and improve handling of unknown
altitudes, but it seems pretty good to me. I can do patient. :-)
If you can offer a sentence or two for the doc (that .xml file you edited)
and a simple file (it can be three points or something) that exercises this
and related formatting options in the test suite, that would be helpful,
but I won't block on it.
RJL